Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit env creation by bumping up isort version #2132

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

mreso
Copy link
Collaborator

@mreso mreso commented Feb 15, 2023

Description

Bumps up isort version which fixes generation of pre-commit environment.

See home-assistant/core#86892 for details

Fixes #(issue)
#2131

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Run
pre-commit install

Create new commit
Logs for Test A

(ts3) ubuntu@ip-172-31-0-197:~/serve$ git commit -m "Bump isort dependency for pre-commit to 5.11.5"
Check python ast.....................................(no files to check)Skipped
Check builtin type constructor use...................(no files to check)Skipped
Check for case conflicts.................................................Passed
Check docstring is first.............................(no files to check)Skipped
Check for merge conflicts................................................Passed
Check JSON...........................................(no files to check)Skipped
Check Toml...........................................(no files to check)Skipped
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Mixed line ending........................................................Passed
Trim Trailing Whitespace.................................................Passed
Check vcs permalinks.....................................................Passed
Check that scripts with shebangs are executable..........................Passed
check for not-real mock methods......................(no files to check)Skipped
use logger.warning(..................................(no files to check)Skipped
type annotations not comments........................(no files to check)Skipped
pycln................................................(no files to check)Skipped
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
[fix/pre-commit-isort ff7175bf] Bump isort dependency for pre-commit to 5.11.5
 1 file changed, 1 insertion(+), 1 deletion(-)
  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@mreso mreso merged commit 7a7cc69 into master Feb 16, 2023
@mreso mreso deleted the fix/pre-commit-isort branch February 16, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants