Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend IMetrics, LogMetric and PrometheusMetric #2165

Merged
merged 26 commits into from
Apr 11, 2023
Merged

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Mar 1, 2023

Description

Implementation of frontend metrics helper classes for LogMetric and PrometheusMetric

Design: #1492

Fixes #2139

Type of change

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

Unit tests included in this PR

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Naman Nandan added 2 commits March 16, 2023 00:57
Reformat code for readability
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2165 (c7310b3) into master (4ea172d) will not change coverage.
The diff coverage is n/a.

❗ Current head c7310b3 differs from pull request most recent head 234ca97. Consider uploading reports for the commit 234ca97 to get more accurate results

@@           Coverage Diff           @@
##           master    #2165   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          73       73           
  Lines        3348     3348           
  Branches       57       57           
=======================================
  Hits         2391     2391           
  Misses        954      954           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Naman Nandan added 2 commits March 16, 2023 14:37
@namannandan namannandan changed the title [WIP] frontend IMetrics, LogMetrics and PrometheusMetrics Frontend IMetrics, LogMetric and PrometheusMetric Mar 17, 2023
Copy link
Collaborator Author

@lxning lxning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@namannandan
Copy link
Collaborator

Approving on @lxning behalf based on the above comment.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lxning Could you please update the appropriate README files for the additional metrics we are collecting.
Also, from. a user point of view, do they have to enable some config to get these metrics?

@namannandan
Copy link
Collaborator

namannandan commented Apr 11, 2023

@agunapal Currently there aren't any new metrics that are going to be collected. The existing metrics are being migrated to a new implementation that supports two modes, i.e log and prometheus. A configuration file is used specify all the metrics that will be collected, which was updated in this PR: #2164
The final PR for the metrics frontend implementation will include necessary documentation for the prometheus mode: #2199

The default mode will be log mode, which follows the exact same logging format used currently. To enable prometheus mode, a config option has been added. Details are in this PR: #2190

This PR implements the necessary helper classes for the frontend metrics implementation refactoring.

@namannandan namannandan merged commit 2aee8fb into master Apr 11, 2023
@namannandan namannandan deleted the issue_2139 branch November 9, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Metric Interface and Class
3 participants