fix: kserve fastapi migration issues #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
jagadeeshi2i
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
+ Coverage 69.39% 69.44% +0.05%
==========================================
Files 77 77
Lines 3441 3450 +9
Branches 57 57
==========================================
+ Hits 2388 2396 +8
- Misses 1050 1051 +1
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lxning
reviewed
Mar 15, 2023
10 tasks
jagadeeshi2i
changed the title
|
@agunapal pls review this PR. |
|
Hi @jagadeeshi2i Can you please update the PR mentioning whats the migration issue and whats the solution |
agunapal
requested changes
Apr 4, 2023
|
Hi @jagadeeshi2i Could you please check. It would be good to have this for the next release, which is soon |
|
@agunapal Pls approve the PR. |
agunapal
approved these changes
Apr 18, 2023
* Update index.md Update to fix a broken link in index.md where the trailing .md is cut off from the management_api.md. Added an anchor link to force the .md to show up. * Update to index.md Update to index.md to fix several links ending in .md that sphinx is breaking. Added anchor links to each link and a corresponding anchor in the affected doc. Tested locally and seems to be working. * Update inference_api.md * Updated typos Fixed typos and updated wordslist.txt * Update wordlist.txt --------- Co-authored-by: sekyonda <7411+sekyonda@users.noreply.ghe.oculus-rep.com> Co-authored-by: lxning <23464292+lxning@users.noreply.github.com>
* Inf2 nightly benchmark * fix linter spellcheck error --------- Co-authored-by: Naman Nandan <namannan@amazon.com>
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
…adeeshi2i/serve into fix/kserve-fastapi-migration
This was referenced May 19, 2023
msaroufim
approved these changes
May 19, 2023
agunapal
pushed a commit
that referenced
this pull request
May 20, 2023
* fix: kserve fastapi migration issues
namannandan
pushed a commit
to namannandan/serve
that referenced
this pull request
May 30, 2023
2 tasks
agunapal
pushed a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KServe 0.10.0 has migrated from tornado server to fastapi server. The PR fixes the issues: #2158 #2156 that are caused as a result of the above migration
Please read our CONTRIBUTING.md prior to creating your first pull reques
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: