Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ONNX test in CI #2363

Merged
merged 18 commits into from
May 31, 2023
Merged

Enable ONNX test in CI #2363

merged 18 commits into from
May 31, 2023

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented May 25, 2023

ONNX is one of our most popular model optimization runtimes, we shouldn't disable this test in CI by default anymore, it's hiding basic failures

Our CI takes 40min and our regression tests take 1h and for context the PyTorch CI takes around 4h. Would just suggest we run regression tests on CI all the time otherwise we get dumb bugs

Fixes #2360

requirements/developer.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #2363 (d49271a) into master (8bd76ee) will increase coverage by 2.70%.
The diff coverage is 94.78%.

❗ Current head d49271a differs from pull request most recent head 951ab0a. Consider uploading reports for the commit 951ab0a to get more accurate results

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
+ Coverage   69.44%   72.15%   +2.70%     
==========================================
  Files          77       78       +1     
  Lines        3450     3641     +191     
  Branches       57       58       +1     
==========================================
+ Hits         2396     2627     +231     
+ Misses       1051     1010      -41     
- Partials        3        4       +1     
Impacted Files Coverage Δ
ts/torch_handler/base_handler.py 55.98% <50.00%> (+0.47%) ⬆️
ts/handler_utils/micro_batching.py 90.90% <90.90%> (ø)
ts/torch_handler/request_envelope/kservev2.py 90.00% <93.75%> (ø)
...l-archiver/model_archiver/model_packaging_utils.py 92.30% <100.00%> (+32.17%) ⬆️
ts/tests/unit_tests/test_micro_batching.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim changed the title Enable ONNX test in CI Enable ONNX test in CI and Enable Regression test on PR May 27, 2023
@msaroufim msaroufim requested review from agunapal, mreso and lxning and removed request for agunapal May 27, 2023 23:34
@msaroufim msaroufim changed the title Enable ONNX test in CI and Enable Regression test on PR Enable ONNX test in CI May 31, 2023
@msaroufim msaroufim merged commit 27a6ed5 into master May 31, 2023
10 of 13 checks passed
@msaroufim msaroufim deleted the msaroufim/enableonnxtest branch May 31, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to load ONNX model from MAR file
3 participants