Ts type annotations

[josephcalise]

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

• I included type annotations for the two functions in the file, I will continue to work on other files as I understand the returns and params.

Fixes part of #1512

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• New feature (non-breaking change which adds functionality)
• This change requires a documentation update
• Addition of type annotations.

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Completed mypy test stated on the issue.

• Test A
  Logs for Test A

• Test B
  Logs for Test B

Checklist:

• Did you have fun?
• Have you added tests that prove your fix is effective or that this feature works?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

[msaroufim]

Thanks @josephcalise please make sure to also add your file here https://github.com/pytorch/serve/blob/master/mypy.ini#L4

[josephcalise]

@msaroufim sorry for the misunderstanding, is this what you mean?

[msaroufim]

Yep that's right it's just to make sure that the type annotation job actually runs in CI

[josephcalise]

Should be added! Thank you for your patience and guidance @msaroufim!

[codecov]

Codecov Report

Merging #2384 (71c41fb) into master (28a2525) will increase coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 71c41fb differs from pull request most recent head c632ce6. Consider uploading reports for the commit c632ce6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2384      +/-   ##
==========================================
+ Coverage   71.92%   72.01%   +0.08%     
==========================================
  Files          78       78              
  Lines        3647     3648       +1     
  Branches       58       58              
==========================================
+ Hits         2623     2627       +4     
+ Misses       1020     1017       -3     
  Partials        4        4              

Impacted Files	Coverage Δ
ts/model_server.py	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[msaroufim]

LGTM and thank you! Feel free to send out more!

[msaroufim]

@mreso @agunapal could you please merge?