Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find torchserve-plugins-sdk artifacts locally #2429

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

namannandan
Copy link
Collaborator

@namannandan namannandan commented Jun 23, 2023

Description

Sanity in CI currently fails with the following error:

A problem occurred evaluating project ':server'.
> Could not resolve all files for configuration ':server:runtimeClasspath'.
   > Could not find org.pytorch:torchserve-plugins-sdk:0.0.4.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/pytorch/torchserve-plugins-sdk/0.0.4/torchserve-plugins-sdk-0.0.4.pom
       - https://jcenter.bintray.com/org/pytorch/torchserve-plugins-sdk/0.0.4/torchserve-plugins-sdk-0.0.4.pom
     Required by:
         project :server

The torchserve-plugins-sdk are currently unavailable via JCenter or Maven Central repositories.

This PR implements a workaround to find torchserve-plugins-sdk artifacts locally using mavenLocal() until they are made available on maven central repository.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2429 (0f50a85) into master (207477d) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 0f50a85 differs from pull request most recent head 2133d32. Consider uploading reports for the commit 2133d32 to get more accurate results

@@            Coverage Diff             @@
##           master    #2429      +/-   ##
==========================================
+ Coverage   71.92%   72.01%   +0.08%     
==========================================
  Files          78       78              
  Lines        3648     3648              
  Branches       58       58              
==========================================
+ Hits         2624     2627       +3     
+ Misses       1020     1017       -3     
  Partials        4        4              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@namannandan namannandan marked this pull request as ready for review June 23, 2023 20:54
@agunapal agunapal self-requested a review June 23, 2023 21:35
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall unless there is an easier workaround @lxning

@namannandan If we include building maven inside

python ts_scripts/install_dependencies.py --environment=dev

then , we can avoid having to update the workflow files

@agunapal agunapal merged commit a77a150 into pytorch:master Jun 23, 2023
12 of 13 checks passed
This was referenced Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants