Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to generate profile graph image #2451

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

mmeendez8
Copy link
Contributor

@mmeendez8 mmeendez8 commented Jul 7, 2023

Description

Image generated with the benchmark script is not using the same folder as the rest of the files. This PR update its path to match latency graph image folder

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@mmeendez8 mmeendez8 changed the title Add path to generate prfile graph image Add path to generate profile graph image Jul 7, 2023
@agunapal agunapal self-requested a review July 12, 2023 19:46
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2451 (768abca) into master (d31b6c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 768abca differs from pull request most recent head bff63cc. Consider uploading reports for the commit bff63cc to get more accurate results

@@           Coverage Diff           @@
##           master    #2451   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files          78       78           
  Lines        3654     3654           
  Branches       58       58           
=======================================
  Hits         2627     2627           
  Misses       1023     1023           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim self-requested a review July 13, 2023 01:31
@agunapal agunapal merged commit 2f5a784 into pytorch:master Jul 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants