Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link #2490

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix broken link #2490

merged 2 commits into from
Jul 21, 2023

Conversation

agunapal
Copy link
Collaborator

Description

Fix broken link

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal requested a review from msaroufim July 21, 2023 21:33
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2490 (eb48742) into master (f5deb1a) will not change coverage.
The diff coverage is n/a.

❗ Current head eb48742 differs from pull request most recent head e2c2c76. Consider uploading reports for the commit e2c2c76 to get more accurate results

@@           Coverage Diff           @@
##           master    #2490   +/-   ##
=======================================
  Coverage   71.90%   71.90%           
=======================================
  Files          78       78           
  Lines        3659     3659           
  Branches       58       58           
=======================================
  Hits         2631     2631           
  Misses       1024     1024           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim requested a review from lxning July 21, 2023 22:01
@agunapal agunapal merged commit e767afe into master Jul 21, 2023
12 of 13 checks passed
@agunapal agunapal deleted the issues/fix_lint branch July 21, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants