Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue #2548

Merged
merged 3 commits into from
Aug 29, 2023
Merged

merge queue #2548

merged 3 commits into from
Aug 29, 2023

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Aug 29, 2023

We've often been in situations where we update master to merge a PR and when there's a lot of PRs to be merged before a release, we end up having to wait to manually click update PR and then manually click merge, This automates it https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Not merging as is I wanna see if the "push to queue" button renders correctly

It works here so gonna merge

image

@msaroufim msaroufim changed the title merge queue Test PR: merge queue Aug 29, 2023
@agunapal agunapal self-requested a review August 29, 2023 00:51
@msaroufim msaroufim requested a review from mreso August 29, 2023 00:51
@mreso mreso requested a review from agunapal August 29, 2023 00:51
@msaroufim msaroufim changed the title Test PR: merge queue Test PR (I will merge): merge queue Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2548 (8a9a1a5) into master (5c0adc6) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a9a1a5 differs from pull request most recent head a9730d2. Consider uploading reports for the commit a9730d2 to get more accurate results

@@           Coverage Diff           @@
##           master    #2548   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files          79       79           
  Lines        3733     3733           
  Branches       58       58           
=======================================
  Hits         2712     2712           
  Misses       1017     1017           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim changed the title Test PR (I will merge): merge queue merge queue Aug 29, 2023
@msaroufim msaroufim added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit d3eeb07 Aug 29, 2023
11 of 13 checks passed
@msaroufim msaroufim deleted the msaroufim/mergeQ branch August 29, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants