Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning newman version to 5.3.2 as mac CI was flaky #2598

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Sep 15, 2023

Description

newman published a new version yesterday, which started breaking our CI

https://www.npmjs.com/package/newman?activeTab=versions

Pinning the version to 5.3.2

This fixes mac regression issues
https://github.com/pytorch/serve/actions/runs/6201889968/job/16839506337

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim
Copy link
Member

Which CI job did this fix? I still see lots of red

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2598 (76fdd70) into master (9cd3389) will not change coverage.
The diff coverage is n/a.

❗ Current head 76fdd70 differs from pull request most recent head 8a4e682. Consider uploading reports for the commit 8a4e682 to get more accurate results

@@           Coverage Diff           @@
##           master    #2598   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          83       83           
  Lines        3839     3839           
  Branches       58       58           
=======================================
  Hits         2721     2721           
  Misses       1114     1114           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to fix the mac test so stamping

@agunapal agunapal added this pull request to the merge queue Sep 15, 2023
@agunapal agunapal changed the title pinning newman version to 5.3.2 as CI was flaky pinning newman version to 5.3.2 as mac CI was flaky Sep 15, 2023
Merged via the queue into master with commit 2bf505b Sep 15, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants