allow paralllevel as 1 to start torchrun npro-per-node #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxning
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
=======================================
Coverage 72.39% 72.39%
=======================================
Files 85 85
Lines 3956 3956
Branches 58 58
=======================================
Hits 2864 2864
Misses 1088 1088
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lxning
changed the title
HamidShojanazeri
approved these changes
Oct 3, 2023
mreso
approved these changes
Oct 3, 2023
| logger.warn("Invalid parallelLevel:{}, set as 1", parallelLevel); | ||
| this.parallelLevel = 1; | ||
| if (parallelLevel < 0) { | ||
| logger.warn("Invalid parallelLevel:{}, set as 0", parallelLevel); |
There was a problem hiding this comment.
if you set to 1 and then to -1 the level stays at 1 and is not set to 0 as indicated by the warning
| @@ -153,7 +153,7 @@ public void startWorker(int port, String deviceIds) | |||
| argl.add(configManager.getMetricsConfigPath()); | |||
|
|
|||
| try { | |||
| latch = new CountDownLatch(model.getParallelLevel()); | |||
| latch = new CountDownLatch(model.getParallelLevel() > 0 ? model.getParallelLevel() : 1); | |||
There was a problem hiding this comment.
nit: you could replace this and in the following with a more concise max(1, model.getParallelLevel())
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR supports the example TP Llama which requires torchrun npro-per-node=1.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
The test is demonstrated in example.
Checklist: