Uncontrolled input fix for ModelManager #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2635 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 85 85
Lines 3905 3905
Branches 58 58
=======================================
Hits 2786 2786
Misses 1115 1115
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
namannandan
approved these changes
Sep 29, 2023
lxning
reviewed
Sep 30, 2023
lxning
reviewed
Sep 30, 2023
| model.getModelDir().getAbsoluteFile()); | ||
|
|
||
| ProcessBuilder processBuilder = new ProcessBuilder(commandParts); | ||
| processBuilder.directory(model.getModelDir().getAbsoluteFile()); |
There was a problem hiding this comment.
This might break some cx environment setting such as SageMaker, where model dir is readonly.
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://github.com/pytorch/serve/security/code-scanning/36
https://github.com/pytorch/serve/security/code-scanning/34