Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/autorecovery loop #2746

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix/autorecovery loop #2746

merged 2 commits into from
Oct 27, 2023

Conversation

mreso
Copy link
Collaborator

@mreso mreso commented Oct 27, 2023

Description

This PR fixes an issue with our auto recovery loop by clearing the backchannel list before reconnecting.

Fixes #(issue)
#2423

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2746 (1e670f3) into master (c1da310) will not change coverage.
The diff coverage is n/a.

❗ Current head 1e670f3 differs from pull request most recent head e6fe66f. Consider uploading reports for the commit e6fe66f to get more accurate results

@@           Coverage Diff           @@
##           master    #2746   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          85       85           
  Lines        3963     3963           
  Branches       58       58           
=======================================
  Hits         2871     2871           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning lxning added this pull request to the merge queue Oct 27, 2023
Merged via the queue into master with commit 20a6e8b Oct 27, 2023
13 checks passed
@mreso mreso deleted the fix/autorecovery_loop branch October 27, 2023 21:18
@chauhang chauhang added this to the v0.10.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants