Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad Security.md to TorchServe site #2784

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

sekyondaMeta
Copy link
Contributor

Adding Security.md doc to TorchServe site

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

Previewed pages locally on my machine

Screenshot 2023-11-10 at 4 43 26 PM Screenshot 2023-11-10 at 4 43 13 PM

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Adding Security.md doc to TorchServe site
@sekyondaMeta
Copy link
Contributor Author

@ankithagunapal Take a look and let me know.
symlink was giving me a lot of trouble (long story), but I found a not so pretty way to include the SECURITY.md file while still leaving it where it is.
The makefile creates a copy of it in the docs folder each time it builds the docs, so any changes to the original should eventually propagate through to the html page.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sekyondaMeta . Just to be clear, do we need to copy the file and send a new PR every time the security.md is updated?

@agunapal
Copy link
Collaborator

@ankithagunapal Take a look and let me know. symlink was giving me a lot of trouble (long story), but I found a not so pretty way to include the SECURITY.md file while still leaving it where it is. The makefile creates a copy of it in the docs folder each time it builds the docs, so any changes to the original should eventually propagate through to the html page.

Just saw your comment. This is great. Thanks!

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Nov 13, 2023
Merged via the queue into pytorch:master with commit 8f5fc88 Nov 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants