Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include queue time in benchmark report #2854

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Include queue time in benchmark report #2854

merged 2 commits into from
Dec 15, 2023

Conversation

sachanub
Copy link
Collaborator

@sachanub sachanub commented Dec 14, 2023

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Creating PR to include queue time in the benchmark report.

Tests run:

Ran benchmark locally with resnet50.yaml with batch sizes 1, 2, 4, 8, 16 and concurrency 4. 10000 requests are used for inference.

---
---
resnet50:
    scripted_mode:
        benchmark_engine: "ab"
        url: "file:///home/model-server/torch_compile_ab_benchmarks/resnet50/resnet-50-scripted.mar"
        workers:
            - 4
        batch_delay: 100
        batch_size:
            - 1
            - 2
            - 4
            - 8
            - 16
        requests: 10000
        concurrency: 100
        input: "/serve/examples/image_classifier/kitten.jpg"
        handler_profiling: True
        backend_profiling: True
        exec_env: "local"
        processors:
            - "cpu"
            - "gpus": "all"

The AB report and metrics can be found be in this tar file:
resnet_reports.tar.gz

As evident from the reports, the P50, P90 and P99 of the queue times can be found in the ab_report.csv and stats_metrics.json files.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachanub sachanub added this pull request to the merge queue Dec 15, 2023
Merged via the queue into master with commit eb6c1e8 Dec 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants