Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid warning log #2867

Merged
merged 8 commits into from
Jan 23, 2024
Merged

remove invalid warning log #2867

merged 8 commits into from
Jan 23, 2024

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Dec 22, 2023

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning requested a review from agunapal December 26, 2023 02:42
@@ -214,11 +214,6 @@ private void initModelStore() throws InvalidSnapshotException, IOException {
if (marMinWorkers > 0 && marMaxWorkers >= marMinWorkers) {
minWorkers = marMinWorkers;
maxWorkers = marMaxWorkers;
} else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone gives faulty values like 0, -1 etc, shouldn't we have a warning?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lxning lxning enabled auto-merge January 23, 2024 21:19
@lxning lxning added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 35b0b93 Jan 23, 2024
13 checks passed
@lxning lxning self-assigned this Feb 27, 2024
@lxning lxning added this to the v0.10.0 milestone Feb 27, 2024
@lxning lxning added this to Done in v0.10.0 lifecycle Feb 27, 2024
@lxning lxning added the p1 mid priority label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality p1 mid priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants