Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial compile error on mac x86 #2927

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix partial compile error on mac x86 #2927

merged 3 commits into from
Feb 5, 2024

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Feb 5, 2024

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test
cd serve/cpp
./build.sh
......

cd _build/src
find . -name "*.dylib"
./backends/libts_backends_protocol.dylib
./backends/libts_backends_core.dylib
./utils/libfoo.dylib
./utils/libts_utils.dylib

Note:
llamacpp still has ggml ld: no symbol issues

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning requested a review from mreso February 5, 2024 05:22
@lxning lxning changed the title Fix compile error on mac x86 Fix partial compile error on mac x86 Feb 5, 2024
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreso mreso enabled auto-merge February 5, 2024 19:32
@mreso mreso added this pull request to the merge queue Feb 5, 2024
Merged via the queue into master with commit fa0f1e3 Feb 5, 2024
13 checks passed
@lxning lxning self-assigned this Feb 27, 2024
@lxning lxning added bug Something isn't working c++ labels Feb 27, 2024
@lxning lxning added this to the v0.10.0 milestone Feb 27, 2024
@lxning lxning added this to Done in v0.10.0 lifecycle Feb 27, 2024
@lxning lxning added the p0 high priority label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ p0 high priority
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants