Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for kserve nightly failure #3079

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Apr 10, 2024

Description

KServe nightlies are failing because of KServe's dependency on Ray Serve.

This PR downgrades the version of rayserve as suggested by KServe team , which fixes the problem

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Default
model-server@41267f0551c9:~$ pip list | grep -i serve
kserve                          0.12.0
torchserve-nightly              2024.4.8
model-server@41267f0551c9:~$ pip list | grep -i ray  
ray                             2.10.0
model-server@41267f0551c9:~$ exit
exit
Traceback (most recent call last):
  File "/home/model-server/kserve_wrapper/__main__.py", line 6, in <module>
    import kserve
  File "/home/venv/lib/python3.9/site-packages/kserve/__init__.py", line 18, in <module>
    from .model_server import ModelServer
  File "/home/venv/lib/python3.9/site-packages/kserve/model_server.py", line 27, in <module>
    from ray.serve.handle import RayServeHandle
ImportError: cannot import name 'RayServeHandle' from 'ray.serve.handle' (/home/venv/lib/python3.9/site-packages/ray/serve/handle.py)
  • After fix
model-server@a5b9bcb5c9bc:~$ pip list | grep -i ray
ray                             2.9.3
model-server@a5b9bcb5c9bc:~$ pip list | grep -i kserve
kserve                          0.12.0

model-server@c7199beae5a5:~$ python
Python 3.9.19 (main, Apr  6 2024, 17:57:55) 
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import kserve
>>> 

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal changed the title Issues/kserve downgrade version Workaround for kserve nightly failure Apr 10, 2024
@agunapal agunapal marked this pull request as ready for review April 10, 2024 21:01
@agunapal agunapal added this pull request to the merge queue Apr 10, 2024
Merged via the queue into master with commit 322615c Apr 10, 2024
13 checks passed
@agunapal agunapal deleted the issues/kserve_downgrade_version branch April 12, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants