Sequence batch via http #3142
Merged
Sequence batch via http #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxning
added
documentation
mreso
requested changes
May 13, 2024
frontend/server/src/main/java/org/pytorch/serve/grpcimpl/InferenceImpl.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/job/JobGroup.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/util/ApiUtils.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java
Outdated
Show resolved
Hide resolved
| @@ -960,6 +971,34 @@ public Double getTimeToExpiration() { | |||
| return 0.0; | |||
| } | |||
|
|
|||
| public String getTsHeaderKeySequenceId() { | |||
There was a problem hiding this comment.
See above. This gets unnecessary if you move the keys to their own module.
There was a problem hiding this comment.
This function is to get the key name for the sequence id in headers.
frontend/server/src/main/java/org/pytorch/serve/wlm/WorkerThread.java
Outdated
Show resolved
Hide resolved
mreso
approved these changes
May 14, 2024
|
Removing from queue so we can address the last issue with the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
pytest test_example_stateful_http.py
======================================= test session starts =======================================
platform linux -- Python 3.10.14, pytest-7.3.1, pluggy-1.4.0
rootdir: /home/ubuntu/serve
plugins: cov-4.1.0, mock-3.12.0
collected 1 item
test_example_stateful_http.py . [100%]
======================================== 1 passed in 5.37s ========================================
Checklist: