Add regroup method to ActiveRecord #47010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
added a commit
to Shopify/tapioca
that referenced
this pull request
Jul 19, 2023
Rails PR: rails/rails#47010
kamipo
added a commit
that referenced
this pull request
Sep 26, 2023
This was accidentally changed at #47010.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Oct 14, 2023
…iveRecordAllMethod` Follow up rails/rails#44446, rails/rails#37944, rails/rails#46503, and rails/rails#47010. This PR supports some Rails 7.1's new querying methods for `Rails/RedundantActiveRecordAllMethod`.
9 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Oct 14, 2023
…iveRecordAllMethod` Follow up rails/rails#44446, rails/rails#37944, rails/rails#46503, and rails/rails#47010. This PR supports some Rails 7.1's new querying methods for `Rails/RedundantActiveRecordAllMethod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Currently there is no one-method way to override previously set
groupstatement (as is the case forselect,whereandreorder).Detail
Adds
regroupandregroup!methods that overridegroup_valuesinstead of appending to the array (as is the case for#group).Additional information
Alternative solutions for
Post.group(:title).regroup(:author)is:Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]