feat: allow specifying expected images directory #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, it is not needed to find previous runs and download an artifact. Instead, the images are copied from the expected images directory and compared immediately.
|
@bokuweb friendly ping, any chance you might have capacity to look at this PR? 🙏 |
|
@kopancek thanks!i'l l check |
bokuweb
reviewed
Jul 2, 2024
bokuweb
reviewed
Jul 2, 2024
src/config.ts
Outdated
| @@ -114,6 +118,8 @@ export const getConfig = (): Config => { | |||
| const imageDirectoryPath = core.getInput('image-directory-path'); | |||
| validateGitHubToken(githubToken); | |||
| validateImageDirPath(imageDirectoryPath); | |||
| const expectedImagesDirectoryPath = core.getInput('expected-images-directory-path') ?? null; | |||
| validateImageDirPath(imageDirectoryPath, true); | |||
There was a problem hiding this comment.
maybe it is not needed to add allowEmpty flag.
Suggested change
| validateImageDirPath(imageDirectoryPath, true); | |
| if (expectedImagesDirectoryPath) { | |
| validateImageDirPath(expectedImagesDirectoryPath); | |
| } |
There was a problem hiding this comment.
Sorry, bad code from me. Changed accordingly, but using a null check instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it is not needed to find previous runs and download an artifact. Instead, the images are copied from the expected images directory and compared immediately.