Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate building of Docker images into the GitHub registry. #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jinnatar
Copy link

@jinnatar jinnatar commented Nov 1, 2021

There are already 3rd party images published on Dockerhub that are wildly out of date. So one automatically up to date official image is probably better than having people rely on unofficial images.

  • Any push to the master branch updates the :latest label
  • Any tag push to master will also be labeled with the tag name, so your releases will get stable labels.
  • Any push to any other branch is labeled with the branch name and the short hash id of the commit.

There are already 3rd party images published on Dockerhub that are wildly out of date. So one automatically up to date official image is probably better than having people rely on unofficial images.

- Any push to the `master` branch updates the `:latest` label
- Any tag push to `master` will also be labeled with the tag name, so your releases will get stable labels.
- Any push to any other branch is labeled with the branch name and the short hash id of the commit.
@retzkek
Copy link
Owner

retzkek commented Nov 12, 2021

Thanks, this looks great. Sorry I just haven't had a chance to review it yet.

@jinnatar
Copy link
Author

Friendly poke @retzkek , any chance you could take a look at this one? It follows very closely the GitHub provided example code of automatically pushing images and requires no further setup on your part since the necessary authentication tokens are autopopulated by the GitHub state runner.

If the .git directory is included, the build fails on a new golang
feature that naively assumes a build environment with a .git folder has
git installed.
@retzkek
Copy link
Owner

retzkek commented Apr 18, 2022

Sorry @Artanicus I've had a lot going on, and haven't even been farming for a couple months now. If you'd like to take over maintenance I'll put a link to your repo in the README and archive this.

@jinnatar
Copy link
Author

Sure, that works for me. I think there was an option somewhere within repo settings to "transfer" ownership. The core benefit being that it archives the original and leaves URL redirects so that any clones still continue to function.

jinnatar added a commit to jinnatar/chia_exporter that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants