Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine options bindings pt1 #36

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Engine options bindings pt1 #36

merged 2 commits into from
Feb 18, 2023

Conversation

dottorblaster
Copy link
Collaborator

@dottorblaster dottorblaster commented Feb 14, 2023 •
edited
Loading

Wrap the vast majority of the Engine options.

@dottorblaster dottorblaster self-assigned this Feb 14, 2023
fabriziosestito
fabriziosestito reviewed Feb 14, 2023
View reviewed changes
lib/rhai/engine.ex Outdated Show resolved Hide resolved
@dottorblaster dottorblaster force-pushed the wrap-engine branch 4 times, most recently from 44fb97d to 3ad83e7 Compare February 17, 2023 11:51
@dottorblaster dottorblaster marked this pull request as ready for review February 17, 2023 11:52
fabriziosestito
fabriziosestito approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix warning in tests and go

@fabriziosestito fabriziosestito changed the title Wrap engine functions Engine options bindings Feb 18, 2023
@fabriziosestito fabriziosestito added the enhancement New feature or request label Feb 18, 2023
@fabriziosestito fabriziosestito changed the title Engine options bindings Engine options bindings pt1 Feb 18, 2023
@fabriziosestito fabriziosestito merged commit 16a9a03 into main Feb 18, 2023
@fabriziosestito fabriziosestito deleted the wrap-engine branch May 21, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziosestito fabriziosestito fabriziosestito approved these changes

Assignees

@dottorblaster dottorblaster

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dottorblaster @fabriziosestito