Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BigNumber instead of number type for amount #968

Open
shawnxie999 opened this issue Apr 1, 2024 · 2 comments
Open

Use BigNumber instead of number type for amount #968

shawnxie999 opened this issue Apr 1, 2024 · 2 comments
Labels
bug Something isn't working cleanup This issue is for cleaning up existing code.

Comments

@shawnxie999
Copy link
Collaborator

shawnxie999 commented Apr 1, 2024

For amount field, it has the number type which can support around 53 bit number. However, an issue currency amount has the maximum value of 9999999999999999 * 10^80, which is not a value that number can store. Explorer should change to a type(eg. BigNumber) that can store these large values. This would likely affect a lot of places in the repo, such as helper functions.

@shawnxie999 shawnxie999 added bug Something isn't working cleanup This issue is for cleaning up existing code. labels Apr 1, 2024
@Awais2662
Copy link

Awais2662 commented Apr 1, 2024 via email

@pdp2121
Copy link
Collaborator

pdp2121 commented Apr 2, 2024

Thanks @shawnxie999 for raising the issue! We have added this ticket to our backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup This issue is for cleaning up existing code.
Projects
None yet
Development

No branches or pull requests

3 participants