Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade Status renders on data error #1000

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Jun 12, 2024

High Level Overview of Change

The VHS is experiencing an intermittent issue with CORS header that causes occasional disruption in data fetching for the Upgrade Status chart. This PR will add checks so to ensure the chart renders even when there's a disruption.

Screenshot 2024-06-12 at 4 13 54 PM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a testcase too?

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Jul 5, 2024

I will add test cases

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Jul 8, 2024

@mvadari I have updated the logic. Aggregation for nodes and validators will be handled separately (in case one fails, it would still update the other).

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Jul 8, 2024

Not sure why npm run test:ci succeed locally but fails on GitHub

@mvadari
Copy link
Collaborator

mvadari commented Jul 8, 2024

Not sure why npm run test:ci succeed locally but fails on GitHub

Usually due to flakiness or something, or missing an async/await somewhere.

@pdp2121 pdp2121 requested a review from mvadari July 8, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants