-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade Status renders on data error #1000
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a testcase too?
I will add test cases |
@mvadari I have updated the logic. Aggregation for nodes and validators will be handled separately (in case one fails, it would still update the other). |
…xplorer into upgrade-status-stablize
Not sure why |
Usually due to flakiness or something, or missing an |
High Level Overview of Change
The VHS is experiencing an intermittent issue with CORS header that causes occasional disruption in data fetching for the Upgrade Status chart. This PR will add checks so to ensure the chart renders even when there's a disruption.
Type of Change