Breakdown tab for payments and offercreates #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
May 22, 2024
mvadari
reviewed
May 22, 2024
mvadari
reviewed
May 22, 2024
mvadari
reviewed
May 22, 2024
| // amountToBalance, | ||
| // } from 'xrpl-tx-path-parser' | ||
|
|
||
| export const BreakDownTab: FC<{ data: any }> = ({ data }) => { |
There was a problem hiding this comment.
Any objection to adding this breakdown to the existing "Detailed" tab?
|
Looks awesome! Probably the dropdown would need a bit redesign, which could be great for reusability as well: |
fix spelling Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
use of ternary Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
now in place, I think its ready for another round of review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a breakdown section to payments and offercreates
Context of Change
This adds the ability to show where the liquidity for the transaction was sourced. Via AMM/DEX/DIRECT and if RIPPLING was involved.
Type of Change