-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the nodes table #987
base: staging
Are you sure you want to change the base?
Sort the nodes table #987
Conversation
{node.io_latency_ms && node.io_latency_ms > 1} | ||
</td> | ||
</tr> | ||
) | ||
|
||
const compareSemanticVersions = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests have now been added that cover the compareSemanticVersions, via sorting the Version column.
Also, could you add an image to the description showing how the arrow would look like? Thanks! |
screen shots added |
Add sorting to the nodes table.
Context of Change
Much needed ability to sort the tables of nodes via the headers.
Type of Change