Lift the deprecation from ArrayNode#each_value
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR lifts the deprecation from `ArrayNode#each_value` for the following reasons: 1. `HashNode#each_value` and `HashNode#each_key` are not deprecated. - `HashNode#each_value` ... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L76-L89 - `HashNode#each_key` ... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L52-L65 2. `node.values.each` is recommended by `Style/HashEachMethods` cop to be replaced with `each_value` instead of `values.each`. And `node.each_value do |value|` is clearer in intent than `node.children.each do |value|`. Since it is a soft deprecation in documentation only, it has not been added to the changelog.
|
You are right, thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts the deprecation from
ArrayNode#each_valuefor the following reasons:HashNode#each_valueandHashNode#each_keyare not deprecated.HashNode#each_value... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L76-L89HashNode#each_key... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L52-L65node.values.eachis recommended byStyle/HashEachMethodscop to be replaced witheach_valueinstead ofvalues.each. Andnode.each_value do |value|is clearer in intent thannode.children.each do |value|.Since it is a soft deprecation in documentation only, it has not been added to the changelog.