Skip to content

Commit

Permalink
Cut 2.17.2
Browse files Browse the repository at this point in the history
  • Loading branch information
koic committed Oct 27, 2022
1 parent 964268c commit 43277d7
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 29 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## master (unreleased)

## 2.17.2 (2022-10-27)

### Bug fixes

* [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][])
Expand Down
2 changes: 1 addition & 1 deletion docs/antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ name: rubocop-rails
title: RuboCop Rails
# We always provide version without patch here (e.g. 1.1),
# as patch versions should not appear in the docs.
version: ~
version: '2.17'
nav:
- modules/ROOT/nav.adoc
30 changes: 3 additions & 27 deletions docs/modules/ROOT/pages/cops_rails.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

| Pending
| Yes
| Yes
| Yes (Unsafe)
| 2.16
| -
|===
Expand Down Expand Up @@ -41,16 +41,6 @@ class HomeController < ApplicationController
end
----

=== Configurable attributes

|===
| Name | Default value | Configurable values

| SafeAutocorrect
| `false`
| Boolean
|===

=== References

* https://rails.rubystyle.guide/#flash-before-render
Expand All @@ -63,7 +53,7 @@ end

| Pending
| Yes
| Yes
| Yes (Unsafe)
| 2.14
| -
|===
Expand Down Expand Up @@ -95,10 +85,6 @@ end
|===
| Name | Default value | Configurable values

| SafeAutocorrect
| `false`
| Boolean

| Include
| `+**/test/**/*.rb+`
| Array
Expand Down Expand Up @@ -5039,7 +5025,7 @@ Rails.public_path.join('path', to, 'file.pdf')

| Pending
| Yes
| Yes
| Yes (Unsafe)
| 2.16
| -
|===
Expand Down Expand Up @@ -5078,16 +5064,6 @@ Rails.root.join('db', 'schema.rb').write(content)
Rails.root.join('db', 'schema.rb').binwrite(content)
----

=== Configurable attributes

|===
| Name | Default value | Configurable values

| SafeAutocorrect
| `false`
| Boolean
|===

== Rails/RootPublicPath

|===
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/rails/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module RuboCop
module Rails
# This module holds the RuboCop Rails version information.
module Version
STRING = '2.17.1'
STRING = '2.17.2'

def self.document_version
STRING.match('\d+\.\d+').to_s
Expand Down
12 changes: 12 additions & 0 deletions relnotes/v2.17.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
### Bug fixes

* [#825](https://github.com/rubocop/rubocop-rails/issues/825): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using condition before `redirect_to`. ([@koic][])
* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when receiver is not block argument for `[]`. ([@koic][])
* [#834](https://github.com/rubocop/rubocop-rails/issues/834): Fix an error for `Rails/WhereNotWithMultipleConditions` when using `where.not` with empty hash literal. ([@koic][])
* [#833](https://github.com/rubocop/rubocop-rails/issues/833): Fix a false positive for `Rails/Pluck` when using multiple block arguments. ([@koic][])

### Changes

* [#832](https://github.com/rubocop/rubocop-rails/issues/832): Mark `Rails/ActionControllerFlashBeforeRender`, `Rails/ActionControllerTestCase`, and `Rails/RootPathnameMethods` cops as unsafe autocorrection. ([@koic][])

[@koic]: https://github.com/koic

0 comments on commit 43277d7

Please sign in to comment.