Merge pull request #1120 from masato-bkn/fix_incorrect_autocorrect_fo…

…r_rails_redundant_active_record_all_method_when_all_has_parentheses

[Fix: #1119] Fix an incorrect autocorrect for `Rails/RedundantActiveRecordAllMethod`  when `all` has parentheses

changelog/fix_an_incorrect_autocorrect_for_rails_redundant_active_record_all_method_when_all_has_parentheses.md

@@ -0,0 +1 @@
+* [#1119](https://github.com/rubocop/rubocop-rails/issues/1119): Fix an incorrect autocorrect for `Rails/RedundantActiveRecordAllMethod`  when `all` has parentheses. ([@masato-bkn][])

lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -22,6 +22,7 @@ module Rails
       #   user.articles.order(:created_at)
       class RedundantActiveRecordAllMethod < Base
         include ActiveRecordHelper
+        include RangeHelp
         extend AutoCorrector
 
         MSG = 'Redundant `all` detected.'
@@ -134,12 +135,18 @@ def on_send(node)
           return unless followed_by_query_method?(node.parent)
           return if node.receiver.nil? && !inherit_active_record_base?(node)
 
-          range_of_all_method = node.loc.selector
+          range_of_all_method = offense_range(node)
           add_offense(range_of_all_method) do |collector|
             collector.remove(range_of_all_method)
             collector.remove(node.parent.loc.dot)
           end
         end
+
+        private
+
+        def offense_range(node)
+          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
+        end
       end
     end
   end

spec/rubocop/cop/rails/redundant_active_record_all_method_spec.rb

@@ -280,6 +280,31 @@
         RUBY
       end
     end
+
+    context 'when `all` has parentheses' do
+      it 'does not register an offense when no method follows `all`' do
+        expect_no_offenses(<<~RUBY)
+          User.all()
+        RUBY
+      end
+
+      it 'registers an offense and corrects when method in `ActiveRecord::Querying::QUERYING_METHODS` follows `all`' do
+        expect_offense(<<~RUBY)
+          User.all().order(:created_at)
+               ^^^^^ Redundant `all` detected.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          User.order(:created_at)
+        RUBY
+      end
+
+      it 'does not register an offense when method not in `ActiveRecord::Querying::QUERYING_METHODS` follows `all`' do
+        expect_no_offenses(<<~RUBY)
+          User.all().do_something
+        RUBY
+      end
+    end
   end
 
   context 'with no receiver' do