Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the outdated Rails/ActionFilter cop #1039

Closed
phil-workato opened this issue Jun 30, 2023 · 1 comment · Fixed by #1149
Closed

Remove the outdated Rails/ActionFilter cop #1039

phil-workato opened this issue Jun 30, 2023 · 1 comment · Fixed by #1149
Labels
enhancement New feature or request

Comments

@phil-workato
Copy link

Is your feature request related to a problem? Please describe.

*_filter methods were removed in Rails 4.2

We have minimum_target_rails_version, but no maximum_target_rails_version.

Specifying EnforcedStyle: filter in .rubocop.yml would make the cop go insane, register inappropriate offences, and make improper corrections.

Describe the solution you'd like

Remove the cop?
@koic
Copy link
Member

koic commented Sep 6, 2023

Indeed! OTOH, Removing cop is a breaking change, It should start with Enabled: false and soft deprecation by documentation.

@koic koic added the enhancement New feature or request label Sep 6, 2023
koic added a commit to koic/rubocop-rails that referenced this issue Oct 10, 2023
@koic
[Fix rubocop#1039] Deprecate Rails/ActionFilter
e051432 
Fixes rubocop#1039.

This PR deprecates `Rails/ActionFilter`. Because the `*_filter` methods were removed in Rails 4.2,
and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
@koic koic mentioned this issue Oct 10, 2023
Merged
9 tasks
koic added a commit to koic/rubocop-rails that referenced this issue Oct 10, 2023
@koic
[Fix rubocop#1039] Deprecate Rails/ActionFilter cop
1874ad8 
Fixes rubocop#1039.

This PR deprecates `Rails/ActionFilter` cop. Because the `*_filter` methods were removed in Rails 4.2,
and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
koic added a commit that referenced this issue Oct 12, 2023
@koic
Merge pull request #1149 from koic/deprecate_rails_action_filter_cop
5624268 
[Fix #1039] Deprecate `Rails/ActionFilter` cop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #1039] Deprecate Rails/ActionFilter cop koic/rubocop-rails
2 participants
@koic @phil-workato