Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: Lexically Scoped Action Filter cop #1078

Closed
ydakuka opened this issue Aug 26, 2023 · 0 comments · Fixed by #1100
Closed

Cop idea: Lexically Scoped Action Filter cop #1078

ydakuka opened this issue Aug 26, 2023 · 0 comments · Fixed by #1100
Labels
bug Something isn't working

Comments

@ydakuka
Copy link

ydakuka commented Aug 26, 2023

Reference: https://rails.rubystyle.guide/#lexically-scoped-action-filter

Actual behavior

I have the code:

# frozen_string_literal: true

class UsersController < ApplicationController
  before_action :require_login, only: :export
end

I will run rubocop and not get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/controllers/users_controller.rb
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
@koic koic added the bug Something isn't working label Aug 26, 2023
vlad-pisanov added a commit to vlad-pisanov/rubocop-rails that referenced this issue Aug 31, 2023
koic added a commit that referenced this issue Aug 31, 2023
…tion_filter

[Fix #1078] Fix false negative for `Rails/LexicallyScopedActionFilter`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants