Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rails/HttpStatus cop #1080

Closed
ydakuka opened this issue Aug 26, 2023 · 1 comment · Fixed by #1101
Closed

Improve Rails/HttpStatus cop #1080

ydakuka opened this issue Aug 26, 2023 · 1 comment · Fixed by #1101
Labels
enhancement New feature or request

Comments

@ydakuka
Copy link

ydakuka commented Aug 26, 2023

Reference: https://rails.rubystyle.guide/#http-status-code-symbols

Actual behavior

If I have the following code:

# frozen_string_literal: true

class ProductsController < ApplicationController
  def index
    render status: '403'
  end
end

or

# frozen_string_literal: true

class ProductsController < ApplicationController
  def index
    render status: 'forbidden'
  end
end

I will run rubocop and not get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/controllers/products_controller.rb 
Inspecting 1 file
.

1 file inspected, no offenses detected

Expected behavior

# frozen_string_literal: true

class ProductsController < ApplicationController
  def index
    render status: :forbidden
  end
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
@koic
Copy link
Member

koic commented Sep 1, 2023

render status: 'forbidden' does not seem to be a valid argument compatible with the symbol argument, so it probably shouldn't be detected.

@koic koic added the enhancement New feature or request label Sep 1, 2023
koic added a commit to koic/rubocop-rails that referenced this issue Sep 1, 2023
Resolves rubocop#1080.

This PR makes `Rails/HttpStatus` aware of string number status.
@koic koic closed this as completed in #1101 Sep 5, 2023
koic added a commit that referenced this issue Sep 5, 2023
…ring_number_status

[Fix #1080] Make `Rails/HttpStatus` aware of string number status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants