Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rails/TimeZone cop, don’t use String#to_time #1094

Closed
ydakuka opened this issue Aug 27, 2023 · 0 comments · Fixed by #1096
Closed

Improve Rails/TimeZone cop, don’t use String#to_time #1094

ydakuka opened this issue Aug 27, 2023 · 0 comments · Fixed by #1096
Labels
enhancement New feature or request

Comments

@ydakuka
Copy link

ydakuka commented Aug 27, 2023

Reference: https://rails.rubystyle.guide/#to-time

Actual behavior

I have the code:

# frozen_string_literal: true

class User < ApplicationRecord
  def method
    '2015-03-02 19:05:37'.to_time
  end
end

I will run rubocop and not get any offenses:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/models/user.rb
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
@koic koic added the enhancement New feature or request label Aug 28, 2023
koic added a commit to koic/rubocop-rails that referenced this issue Aug 28, 2023
Fixes rubocop#1094.

This PR make `Rails/TimeZone` aware of `String#to_time`.
koic added a commit that referenced this issue Aug 30, 2023
…ng_to_time

[Fix #1094] Make `Rails/TimeZone` aware of `String#to_time`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants