False-positive in Rails/HttpPositionalArguments

[pyromaniac]

When routes are defined in controller specs, they might use the same method manes as this cop checks. We probably have to determine is we are inside of the Rails.application.routes.draw do or routes do block (the latter one is provided by rspec) and ignore HTTP verb method calls there.

---

Expected behavior

I expect the cop to ignore HTTP method request helpers invocation inside of routes definitions.

Actual behavior

Rails/HttpPositionalArguments catches route definition helpers invocation and raises an offense.

Steps to reproduce the problem

# frozen_string_literal: true

RSpec.describe FooController do
  before do
    routes do
      get :list, on: :collection
    end

    Rails.application.routes.draw do
      get :list, on: :collection
    end
  end

  specify do
    get :list, filter: 42
  end
end

Produces:

rubocop spec/controllers/foo_controller_spec.rb
Inspecting 1 file
C

Offenses:

spec/controllers/foo_controller_spec.rb:6:18: C: [Correctable] Rails/HttpPositionalArguments: Use keyword arguments instead of positional arguments for http call: get.
      get :list, on: :collection
                 ^^^^^^^^^^^^^^^
spec/controllers/foo_controller_spec.rb:10:18: C: [Correctable] Rails/HttpPositionalArguments: Use keyword arguments instead of positional arguments for http call: get.
      get :list, on: :collection
                 ^^^^^^^^^^^^^^^
spec/controllers/foo_controller_spec.rb:15:16: C: [Correctable] Rails/HttpPositionalArguments: Use keyword arguments instead of positional arguments for http call: get.
    get :list, filter: 42
               ^^^^^^^^^^

1 file inspected, 3 offenses detected, 3 offenses auto-correctable

RuboCop version

$ [bundle exec] rubocop -V
1.20.0 (using Parser 3.0.2.0, rubocop-ast 1.11.0, running on ruby 2.7.4 x86_64-darwin20)
  - rubocop-performance 1.11.5
  - rubocop-rails 2.11.3
  - rubocop-rspec 2.4.0