Rails/RedundantPresenceValidationOnBelongsTo should not match strict validations

[gaffneyc]

Expected behavior

Strict changes validations to raise a ActiveModel::StrictValidationFailed instead of populating errors. Since this changes the default behavior the presence validation is not redundant.

belongs_to :project
validates :project, presence: true, strict: true

Actual behavior

user.rb:3:23: C: [Correctable] Rails/RedundantPresenceValidationOnBelongsTo: Remove explicit presence validation for project.
  validates :project, presence: true, strict: true

Steps to reproduce the problem

With user.rb as

class User < ActiveRecord::Base
  belongs_to :project
  validates :project, presence: true, strict: true
end

rubocop user.rb

RuboCop version

1.24.0 (using Parser 3.0.3.2, rubocop-ast 1.15.1, running on ruby 3.0.3 x86_64-linux)
  - rubocop-performance 1.13.0
  - rubocop-rails 2.13.0

[pirj]

Thanks for reporting!

[pirj]

Hey @gaffneyc, I've sent a fix in #610, does it fix your case?

[gaffneyc]

I skimmed the commit and it looks like it should be a fix. I'm not able to test it locally at the moment.