Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails/StripHeredoc bad autocorrect when squiggly already present #731

Closed
vlad-pisanov opened this issue Jun 27, 2022 · 0 comments · Fixed by #733
Closed

Rails/StripHeredoc bad autocorrect when squiggly already present #731

vlad-pisanov opened this issue Jun 27, 2022 · 0 comments · Fixed by #733
Labels
bug Something isn't working

Comments

@vlad-pisanov
Copy link
Contributor

Consider

s = <<~EOF.strip_heredoc
  foo
EOF

Rails/StripHeredoc autocorrects this to:

s = <<~~EOF
  foo
EOF

Expected:

s = <<~EOF
  foo
EOF

Rubocop:

1.30.1 (using Parser 3.1.2.0, rubocop-ast 1.18.0, running on ruby 2.6.9 x86_64-darwin21)
  - rubocop-minitest 0.20.1
  - rubocop-performance 1.14.2
  - rubocop-rails 2.15.1
@koic koic added the bug Something isn't working label Jun 27, 2022
kazarin added a commit to kazarin/rubocop-rails that referenced this issue Jun 27, 2022
kazarin added a commit to kazarin/rubocop-rails that referenced this issue Jun 27, 2022
kazarin added a commit to kazarin/rubocop-rails that referenced this issue Jun 27, 2022
kazarin added a commit to kazarin/rubocop-rails that referenced this issue Jun 27, 2022
@koic koic closed this as completed in #733 Jun 28, 2022
koic added a commit that referenced this issue Jun 28, 2022
…ils_strip_heredoc

[Fix #731] Fix an incorrect autocorrect for Rails/StripHeredoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants