Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert default changes to Style/InverseMethods in v2.18 #941

Closed
dduugg opened this issue Mar 2, 2023 · 0 comments · Fixed by #964
Closed

Revert default changes to Style/InverseMethods in v2.18 #941

dduugg opened this issue Mar 2, 2023 · 0 comments · Fixed by #964
Labels
bug Something isn't working

Comments

@dduugg
Copy link

dduugg commented Mar 2, 2023

Is your feature request related to a problem? Please describe.

#935 added entries to the InverseMethods configuration of Style/InverseMethods. I believe this redundant with existing cops Rails/Present and Rails/NegateInclude, but the Rails cops can be scoped to just the parts of the codebase that enable ActiveSupport (ironically, I became aware of this because it caused errors in the custom RuboCop code used by homebrew.)

Describe the solution you'd like

Revert the config/default.yml change in #935

Describe alternatives you've considered

Downstream repos could set InverseMethods back to the core rubocop default, but that could lead to drift issues if the core config changes.
@dduugg dduugg mentioned this issue Mar 2, 2023
Merged
@koic koic added the bug Something isn't working label Mar 29, 2023
@koic koic mentioned this issue Mar 29, 2023
Merged
9 tasks
@koic koic closed this as completed in #964 Mar 30, 2023
@koic koic closed this as completed in b13bf71 Mar 30, 2023
koic added a commit that referenced this issue Mar 30, 2023
@koic
Merge pull request #964 from koic/remove_redundant_config_for_style_i…
968331c 
…nverse_methods

[Fix #941] Remove redundant config for `Style/InverseMethods`
koic added a commit to koic/rubocop-rails that referenced this issue Apr 4, 2023
@koic
[Fix rubocop#888] Make Style/InverseMethods aware of exists?
3b6e08f 
Fixes rubocop#888.

This PR makes `Style/InverseMethods` aware of `exists?`.
Probably simpler than implementing a new named cop. And there will be
no overlap with existing cop as reported in rubocop#941.
@koic koic mentioned this issue Apr 4, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #941] Remove redundant config for Style/InverseMethods koic/rubocop-rails
2 participants
@koic @dduugg