Rails/HttpPositionalArguments does not respect Rack::Test::Methods

[jcraigk]

rubocop/rubocop#7095 Expected behavior

In RSpec tests that use Rack::Test::Methods, the Rails/HttpPositionalArguments cop should not warn about using keyword arguments, as that is not how the Rack::Test::Methods work.

Actual behavior

In RSpec tests that include the line include Rack::Test::Methods and then use the get, post, etc methods supplied in that module, the Rails/HttpPositionalArguments mistakenly warns that keyword arguments should be used. However, the Rack::Test::Methods do not support keyword arguments.

From the Rubocop docs:

# bad
get :new, { user_id: 1}

# good
get :new, params: { user_id: 1 }

Steps to reproduce the problem

Run the Rails/HttpPositionalArguments on an RSpec file that includes the line include Rack::Test::Methods and then uses get with at least one parameter.

RuboCop version

$ rubocop -V
0.74.0 (using Parser 2.6.3.0, running on ruby 2.6.3 x86_64-darwin17)

Tangentially related to rubocop/rubocop#3629

[ShPakvel]

any update on it?

[ezedepetris]

What version of rack-test are you using?, version 0.7.0 require rubocop < 0.50 and >= 0.49, not sure if it might be related to your issue

[jcraigk]

I'm currently seeing the issue with rack-test 1.1.0 and rubocop-rails 2.12.2