Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower #1004

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

r7kamura
Copy link
Contributor

Pathname#glob was added at Ruby 2.5, so it cannot be used on Ruby 2.4 or lower versions.

For example, this false-positive becomes a problem when a gem that uses RuboCop wants to provide code that also supports Ruby 2.4-.

$ ruby --version
ruby 2.4.10p364 (2020-03-31 revision 67879) [x86_64-linux]
$ ruby -r pathname -e "Pathname.new('foo').glob('*')"
-e:1:in `<main>': undefined method `glob' for #<Pathname:foo> (NoMethodError)

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 2c55600 into rubocop:master Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants