Flag break in with_lock for Rails/TransactionExitStatement
#1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splattael
force-pushed
the
rails-transaction-exit-statement-with-lock-fix
branch
from
5752ca7
to
5103efd
Compare
splattael
commented
May 11, 2023
| end | ||
| RUBY | ||
| end | ||
| shared_examples 'flags transaction exit statements' do |method| |
There was a problem hiding this comment.
I've extracted the existing specs into shared_examples to make sure that all cases are covered.
splattael
commented
May 11, 2023
| !statement_node.ancestors.find(&:block_type?).method?(:transaction) | ||
| block_node = statement_node.ancestors.find(&:block_type?) | ||
|
|
||
| RESTRICT_ON_SEND.none? { |name| block_node.method?(name) } |
There was a problem hiding this comment.
The crux of this PR where with_lock was not checked and produced false negatives.
|
Can you update the doc to include |
Previously, the following code was not flagged but is considered
problematic:
ApplicationRecord.with_lock do
break if user.active?
end
splattael
force-pushed
the
rails-transaction-exit-statement-with-lock-fix
branch
from
5103efd
to
673d52e
Compare
|
@koic Done! I've only added a I suppose it's because the same resolution as for |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following code was not flagged but is considered problematic:
Refs:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.