Fix an error for Rails/UniqueValidationWithoutIndex
#1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
fix_an_error_for_rails_unique_validation_without_index
branch
from
8fef179
to
2b2adc5
Compare
koic
reviewed
Jun 18, 2023
| @@ -6,6 +6,7 @@ | |||
| expect_no_offenses(<<~RUBY) | |||
| class User < ApplicationRecord | |||
| validates :account, uniqueness: true | |||
| validates :name, presence: true | |||
There was a problem hiding this comment.
For test independence, Can you make this test case a separate it from this it in the context?
There was a problem hiding this comment.
I made it an independent test. What do you think?
This PR is fix an error for `Rails/UniqueValidationWithoutIndex`.
ydah
force-pushed
the
fix_an_error_for_rails_unique_validation_without_index
branch
from
2b2adc5
to
cdaef41
Compare
|
Anyway, this solves the problem, so let's merge it. Thank you! |
mhenrixon
reviewed
Jun 19, 2023
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix an error for
Rails/UniqueValidationWithoutIndex.Code to reproduce in
models/**/*.rb:Occurred Error:
bundle exec rubocop -V
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.