Fix database adapter detection for nested config #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a database yml is configured with nested named databases (for example: `primary`, `read`, `replica`, etc) the adapter detection fails by only looking for a top-level `adapter` key in the hash. This changes the detection to try the top-level location first, and then also attempt to look for an `adapter` key in the first nested hash under `development` as well.
mjankowski
force-pushed
the
database-adapter-detection
branch
from
84501f7
to
e80345a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a database yml is configured with nested named databases (for example:
primary,read,replica, etc) the adapter detection fails by only looking for a top-leveladapterkey in the hash.This changes the detection to try the top-level location first, and then also attempt to look for an
adapterkey in the first nested hash underdevelopmentas well.