Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1041] Fix a false positive for Rails/Output #1141

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

koic
Copy link
Member

@koic koic commented Oct 5, 2023

Fixes #1041.

This PR fixes a false positive for Rails/Output when output method is called with block argument.

The output method for the bad case is not designed to take a block argument. Thus, by ignoring this, it can likely reduce false positives.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#1041.

This PR fixes a false positive for `Rails/Output`
when output method is called with block argument.

The output method for the bad case is not designed to take a block argument.
Thus, by ignoring this, it can likely reduce false positives.
@koic koic merged commit a4df1b9 into rubocop:master Oct 6, 2023
10 checks passed
@koic koic deleted the fix_a_false_positive_for_rails_output branch October 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant