Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dangerous column names to Rails/DangerousColumnNames #1152

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

r7kamura
Copy link
Contributor

Between rails 7.0.5 and 7.1.0, several more method names were added as dangerous targets, so I will add them to this cop as well in this pull request.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 3629fc9 into rubocop:master Oct 12, 2023
10 checks passed
@koic
Copy link
Member

koic commented Oct 12, 2023

Nice improvement 👍

@r7kamura r7kamura deleted the dangerous-column-names branch October 12, 2023 07:37
@zzak
Copy link

zzak commented Dec 2, 2023

FYI, I think object_id will be allowed in the next 7.1.x release on (rails/rails#50162)

@r7kamura
Copy link
Contributor Author

r7kamura commented Dec 3, 2023

Yes, I plan to create a new pull request for that when a new version of Rails is officially released. Thanks for sharing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants