[Fix #1173] Fix an error for Rails/RedundantActiveRecordAllMethod cop
#1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_error_for_rails_redundant_active_record_all_method
branch
2 times, most recently
from
de758de
to
f91c10a
Compare
…thod` cop Fixes rubocop#1173. This PR fixes an error for `Rails/RedundantActiveRecordAllMethod` cop when used with RuboCop 1.51 or lower. Additionally, it introduces a CI matrix for regression testing with the oldest supported RuboCop version.
koic
force-pushed
the
fix_error_for_rails_redundant_active_record_all_method
branch
2 times, most recently
from
46182c7
to
c9acb7a
Compare
|
Can this be merged @koic? |
koic
deleted the
fix_error_for_rails_redundant_active_record_all_method
branch
|
RuboCop Rails 2.22.2 has now been released. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1173.
This PR fixes an error for
Rails/RedundantActiveRecordAllMethodcop when using RuboCop 1.51 or lower.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.