support postGIS adapter for postgreSQL #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dania02525
force-pushed
the
feature/support_postgis_adapter
branch
from
6cadb4c
to
ef19404
Compare
koic
reviewed
Nov 17, 2023
Dania02525
force-pushed
the
feature/support_postgis_adapter
branch
from
df298a6
to
bdcc1a9
Compare
koic
reviewed
Nov 17, 2023
remove puts rename changelog change wording in changelog update pr number Update lib/rubocop/cop/rails/bulk_change_table.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com> Update changelog/new_support_postgis_adapter_for_postgresql.md Co-authored-by: Koichi ITO <koic.ito@gmail.com>
Dania02525
force-pushed
the
feature/support_postgis_adapter
branch
from
0668a85
to
8528cf7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
postgisadapter, this theRails/BulkChangeTablecop interprets this as a database which does not support bulk alter statements. Since postgis is an extension for postgreSQL, it should be treated the same as postgreSQL when determining if this cop should be run.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.