Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1244] Fix a false positive for Rails/ActionControllerFlashBeforeRender when returning redirect_to #1246

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Earlopain
Copy link
Contributor

Closes #1244

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…ashBeforeRender` when returning `redirect_to`
@koic koic merged commit 56d11bd into rubocop:master Mar 4, 2024
14 checks passed
@koic
Copy link
Member

koic commented Mar 4, 2024

Thanks!

@Earlopain Earlopain deleted the fix-1244 branch March 4, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for Rails/ActionControllerFlashBeforeRender when using return redirect_to
2 participants