[Fix #1280] Handle change_column_null for BulkChangeTable #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
May 25, 2024
| @@ -113,8 +113,10 @@ class BulkChangeTable < Base | |||
| MYSQL_COMBINABLE_ALTER_METHODS = %i[rename_column add_index remove_index].freeze | |||
|
|
|||
| POSTGRESQL_COMBINABLE_TRANSFORMATIONS = %i[change_default].freeze | |||
| POSTGRESQL_COMBINABLE_TRANSFORMATIONS_6_1_PLUS = %i[change_null].freeze | |||
There was a problem hiding this comment.
Can you update the name to something like the following?
Suggested change
| POSTGRESQL_COMBINABLE_TRANSFORMATIONS_6_1_PLUS = %i[change_null].freeze | |
| POSTGRESQL_COMBINABLE_TRANSFORMATIONS_SINCE_6_1 = %i[change_null].freeze |
koic
reviewed
May 25, 2024
|
|
||
| POSTGRESQL_COMBINABLE_ALTER_METHODS = %i[change_column_default].freeze | ||
| POSTGRESQL_COMBINABLE_ALTER_METHODS_6_1_PLUS = %i[change_column_null].freeze |
There was a problem hiding this comment.
Suggested change
| POSTGRESQL_COMBINABLE_ALTER_METHODS_6_1_PLUS = %i[change_column_null].freeze | |
| POSTGRESQL_COMBINABLE_ALTER_METHODS_SINCE_6_1 = %i[change_column_null].freeze |
|
@ccutrer ping |
change_column_null is only combinable with PostgreSQL, and is only available as change_null within a change_table block since Rails 6.1, so target to only those cases.
|
Constants renamed |
|
It hasn't been renamed. Perhaps it was forgotten to be git pushed? |
ccutrer
force-pushed
the
fix-change-column-null-in-bulk-change-table
branch
from
7b4ccc6
to
e71b373
Compare
🤦, no, I just accidentally pushed to my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change_column_nullis only combinable with PostgreSQL, and is only available aschange_nullwithin achange_tableblock since Rails 6.1, so target to only those cases.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.