Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1286] Mark Rails/SkipsModelValidations as unsafe #1287

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 27, 2024

Fixes #1286.

Rails/SkipsModelValidations cop is unsafe if the receiver object is not an Active Record object. So, this PR marks SkipsModelValidations as unsafe.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#1286.

`Rails/SkipsModelValidations` cop is unsafe if the receiver object is not an Active Record object.
So, this PR marks `SkipsModelValidations` as unsafe.
@koic koic merged commit afcf639 into rubocop:master May 28, 2024
14 checks passed
@koic koic deleted the mark_rails_skips_model_validations_as_unsafe branch May 28, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/SkipsModelValidations false positive when using upsert
1 participant